Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change 'for' in react components to 'htmlFor' #53

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

Devansh-Baghel
Copy link
Contributor

2 react components had a for attribute in label tags. for in JavaScript is a reserved keyword, so react uses htmlFor instead.

Screenshot from 2023-12-28 22-03-18

This produced the following error in the console when copy pasting those components into a react app:

Screenshot from 2023-12-28 22-20-37

This pr fixes this issue in both those files.

@sidiDev sidiDev merged commit 69f1cf5 into MarsX-dev:main Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants